fix(fish): honor GO_TASK_PROGNAME for experiments cache#2730

Open

SergioChan wants to merge 1 commit intogo-task:mainfrom

SergioChan:fix-fish-completion-progname-2727

Contributor

SergioChan commented Mar 9, 2026

Summary

use $GO_TASK_PROGNAME instead of hardcoded task when refreshing fish completion experiment cache
fixes fish completion warnings on distros where the binary name is go-task
keeps completion behavior unchanged for default task installs

Testing

git diff --check
go test ./... (not runnable in this environment: required Go toolchain go1.25 is unavailable via GOTOOLCHAIN download)

Related

Fixes Task completion with the fish shell raise a warning when distro use the go-task name instead of task #2727


          fix(fish): use GO_TASK_PROGNAME for experiments lookup

159599c

trulede added the area: completions label

trulede approved these changes

View reviewed changes

Contributor

trulede left a comment

Fix seems OK.
I'm not familiar with fish and can't verify.

trulede added the state: reviewed label

appenzellergeller commented Mar 18, 2026

I did face the same issue today and have already tried the fix as it is proposed in this PR.
This will unfortunately not work in any case.

The are situations where the __go_task_is_experiment_enabled is called from another script and then the variable $GO_TASK_PROGNAME has not been defined in that scope.

If you add the --inherit-variable GO_TASK_PROGNAME to the function then it will work. See below.

function __go_task_get_experiments --inherit-variable GO_TASK_PROGNAME
[...]
    # Refresh cache
    set -g __go_task_experiments_cache ($GO_TASK_PROGNAME --experiments 2>/dev/null)
[...]
end

trulede removed the state: reviewed label

trulede suggested changes

View reviewed changes

Contributor

trulede left a comment

Would you check if the suggested changes are viable/working:

function __go_task_get_experiments --inherit-variable GO_TASK_PROGNAME
[...]
    # Refresh cache
    set -g __go_task_experiments_cache ($GO_TASK_PROGNAME --experiments 2>/dev/null)
[...]
end

vmaerten self-requested a review

March 18, 2026 20:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: completions